Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before
after
outstanding work
arrays
We have one issue left, which is accepting both arrays of plaintexts and arrays of ciphertexts. The issue is that to support arbitrarily nested arrays, the impl for
Into<FheProgramInput>
has to be generic, but without specialization, or negative type bounds, there's no way to have two blanket impls. Perhaps there is an avenue where FHE programs instead accept e.g.Cipher<[Signed; 5]>
instead of[Cipher<Signed>; 5]
, with appropriateIndex
-ing, however this might make the FHE program body awkward, as you no longer have a "first class" array.supporting dynamic calls on generic programs
Due to limitations of stable rust, this
run
function needs to exist on the fhe program impl, and not a trait. We could put this on a trait, but it would likely have to go on theFheProgramExt
trait (so that we don't screw up vectors of compiled FHE programs), and it would require packing all arguments into a tuple. Once theTuple
trait is stabilized we could avoid that.